[Wallet] Create new carousel component #1555
Conversation
Use updated RN Geth to support hot reloading
jmrossy
requested review from
jeanregisser,
martinvol,
cmcewen,
i1skn and
annakaz
| return ( | ||
| <SafeAreaView style={styles.container}> | ||
| <ScrollView contentContainerStyle={styles.scrollContainer}> | ||
| {/* <DevSkipButton nextScreen={Screens.WalletHome} /> */} |
There was a problem hiding this comment.
As far as I understand, DevSkipButton would not be visible in production builds. So, I'm curious about the reason to comment it.
There was a problem hiding this comment.
Good question, it won't be. it was just a bit in the way as I was dev-ing this screen. Consider everything except the carousel still WIP
Codecov Report
@@ Coverage Diff @@
## master #1555 +/- ##
=========================================
Coverage ? 73.64%
=========================================
Files ? 276
Lines ? 7391
Branches ? 950
=========================================
Hits ? 5443
Misses ? 1837
Partials ? 111
Continue to review full report at Codecov.
|
| <SafeAreaView style={styles.container}> | ||
| <ScrollView contentContainerStyle={styles.scrollContainer}> |
There was a problem hiding this comment.
If there's only the ScrollView in this screen (i.e. nothing outside of it), it's nicer on iOS to have the SafeAreaView be inside the ScrollView so the content doesn't get clipped when overscrolling up or down.
|
Other than the comment I left regarding |
Yeah, shadows in React Native are very limited on android. I've improved it in the later PRs but still doesn't look perfect. |
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
Description
This is the first of many PRs that will build the new optional verification experience.
This adds a new carousel for user education:
https://www.figma.com/file/9lBnIzsABhO8oXE0d0c8Km/Onboarding-and-Verification?node-id=233%3A1559
Remove unused verify input screen
Create new screen for first stage of new verification designs
Tested
In app (android, still TODO iOS but the lib is cross-platform)
Related issues
Backwards compatibility
Yes